QR-code-component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi! 👋

  Nice work on this challenge! 👍

  I have a few suggestions for this solution.

  • Like @CharlieeLuna23 has said earlier, I would also recommend writing the styling with the mobile-first approach. But in this case, it doesn't matter because there's no need for media queries to make the site responsive.
  • Also, I would recommend using either flexbox or grid to place the card in the middle of the page.
  • The alternative text of the QR code is already good. But, you can improve it by telling the users about what the QR code is about. In this case, it will navigate the users to https://www.frontendmentor.io. So, I recommend improving it to "QR code to frontendmentor.io".
  • Lastly, try to fix all the accessibility issues that have been reported.

  Hope this helps. Let me know if you have any questions. 🙂

  Marked as helpful

  1
• 

  LarryTheFatCat•50

  @LarryTheFatCatPosted over 2 years ago

  Thank you!

  Yeah, this is my first time trying to approach with mobile appearance, I'll for sure fix the accessibility issues, and sure, I can improve the text, I'll start working it right now, thank you for the tips! :>

  0
• 

  LarryTheFatCat•50

  @LarryTheFatCatPosted over 2 years ago

  It looks so much better then the photo please don't mind that lol, https://twothreetwo.github.io/QR-code-component/ check here for the actual result

  0

  ---

  

  CharlieeLuna•260

  @CharlieeLuna23Posted over 2 years ago

  @TwoThreeTwo actually it would be best to start working on a mobile first approach and then upscale to desktop. On your styles sheet in your ".card" you might want to clean that a bit and try to not use "position: absolute" :)

  Marked as helpful

  2

  

  LarryTheFatCat•50

  @LarryTheFatCatPosted over 2 years ago

  @CharlieeLuna23

  1: yeah I seriously should lol 2: Yeah I should try but, ty for that :>

  2