QR-Code-Component

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge🎉! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add Semantic HTML tags to your code

  The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page.<main> tag to indicate that it represents the main content of the page. You can wrap up .attribution class within <footer> as a part of semantics.Wrapping the .attribution class within a <footer> element is a great way to improve the semantics and structure of your code. here is the code that u need to add to include semantic tags in ur page

  <main>
  <div class="container">
  ......
  </div>
  </main> 
  <footer>
  <div class="attribution">
  Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
  Coded by <a href="#">Diksha</a>.
  </div>
  </footer>
  

  Marked as helpful

  1

  ---

  

  Diksha•240

  @dvig14Posted over 1 year ago

  Thank you for Feedback @Kamlesh0007

  0

  

  juanc-escobar•40

  @juanc-escobarPosted over 1 year ago

  Thanks for your feedback @Kamlesh0007 , you are absolutely right about the semantics, ill be make sure to implement them, thanks again for your insights I really appreciate it.

  0