qr-code-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Luiza, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove div with container class because it is superfluous
  • remove all margin from card class
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0

  ---

  

  Luiza Moshkin•70

  @la-vizaPosted over 2 years ago

  Hi Deniel! Thanks for your much appreciated help – your suggestions worked. Cheers!

  1