QR-code-component

Community feedback

• 

  imad•3,330

  @imadvvPosted about 2 years ago

  Greeting Darío Rodríguez!! Congratulations for completing your first challenge!, 👏👏👏 well done.

  You're so close to center the card perfectly on the middle of the page, all you need is min-height: 100vh; and justify-content: center; on the body.

  body {
  	display: flex;
  	flex-direction: column;
  	align-items: center;
  	background-color: #D5E1EF;
  
  
  	min-height: 100vh;
  	justify-content: center;
  }
  
  

  but overall, you did great, Happy Codding, and have a Good Day/Night

  Marked as helpful

  0
• 

  Adriano•38,410

  @AdrianoEscarabotePosted about 2 years ago

  Hello @Dario2303, how are you?

  Congratulations on the result of your project, it was very good, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag.

  2- I noticed that the container was not so centralized, so I made some changes to the code to solve this:

  body { min-height: 100vh; justify-content: center; }

  The rest is really good! Hope it helps...👍

  Marked as helpful

  0

  ---

  

  Darío Rodríguez•160

  @Dario2303Posted about 2 years ago

  @AdrianoEscarabote thanks Adriano!!

  I'll keep that in mind, it's very useful 👏👏

  1