Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code-component

@Dario2303

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

imad 3,330

@imadvv

Posted

Greeting Darío Rodríguez!! Congratulations for completing your first challenge!, 👏👏👏 well done.

You're so close to center the card perfectly on the middle of the page, all you need is min-height: 100vh; and justify-content: center; on the body.

body {
	display: flex;
	flex-direction: column;
	align-items: center;
	background-color: #D5E1EF;


	min-height: 100vh;
	justify-content: center;
}

but overall, you did great, Happy Codding, and have a Good Day/Night

Marked as helpful

0
Adriano 34,090

@AdrianoEscarabote

Posted

Hello @Dario2303, how are you?

Congratulations on the result of your project, it was very good, but I have some tips that I think you will like:

1- Document should have one main landmark, you could have put all the content inside the main tag.

2- I noticed that the container was not so centralized, so I made some changes to the code to solve this:

body { min-height: 100vh; justify-content: center; }

The rest is really good! Hope it helps...👍

Marked as helpful

0

@Dario2303

Posted

@AdrianoEscarabote thanks Adriano!!

I'll keep that in mind, it's very useful 👏👏

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord