QR-code-component

Community feedback

• 

  Gaurav Pratap Singh•340

  @gauravsingh1281Posted 11 months ago

  Hey Kornkanok, Congratulations on completing this challenge 👏👏. I have some suggestions for you. Whenever you use any image on your site always try to add alternative text for the image in the alt tags sometimes images are not loading properly on the websites so the alternative text gives brief information to the user on what type of image is this.

  for example - if you use the image of a cat on the website for some error it is not visible to the user then the user can see the alternative text whatever you have written in the alt tag. Like this <img src="cat.jpg" alt="cat-image">

  Marked as helpful

  0
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Excellent work!

  A couple of details that can improve your solution:

  • Use semantic tags, every site must have its main.
  • In the text class you placed the wrong padding by leaving a space between the value and the unit type: padding: 22px 10 px, changing it to padding: 22px 10px; or simply removing that 10px that I think It would upset several things.
  • A box-sizing: border-box in the universal selector (*) is quite useful to correctly adjust the padding and margin, although in this case, because of how you laid it out, it is not necessary.

  0