qr-code-component

Community feedback

• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted over 2 years ago

  Hi Sahil

  In response to your question on I have done some amendments to your file style.css

  replace the code from line 28 to 34 with this

  .qr-img > img { width: 90%; height: 70%; border: none; border-radius: 10px; }

  Marked as helpful

  0

  ---

  

  Sahil Sharma•110

  @sahil899Posted over 2 years ago

  @DrMESAZIM heigth:70% total worked. I don't why I was using auto instead giving value in percentage

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think the card image needs to be a bit smaller as seen in the design.

  In terms of accessibility issues simply wrap all your content between main tags

  I hope this helps

  Cheers

  Happy coding 👍

  Marked as helpful

  0
• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills🛠️

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ Fonts are best imported into the document title

  @import url ("https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap");
  
  

  ✅ Try not to use universal selectors and tag selectors. this degrades the support of your code

     .qr-img> img {
       width: 100%;
     }
     .qrcard> * {
       padding: 0.5rem 0;
     }
  
  
  

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  0