Skip to content
Submitted over 2 years ago

Qr-code-component

islombek•280
@islomurodov
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

This site is made only in HTML, CSS.

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted over 2 years ago

    👾Hello islombek, congratulations for your new solution!

    Your solution is just great and there's nothing much to improve here. But if you want to an exercise, you can clean your code and make it even better. For example, you can build this with a simple approach, without using unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading and paragraph.

    See the structure below:

    <body><main><img><h1></h1><p></p></main></body>

    👋 I hope this helps you and happy coding!

    Marked as helpful
    0
    islombek•280
    @islomurodovPosted about 2 years ago

    @correlucas Thanks bro

    0
  • Luis David Guaiquirian•300
    @luisgcodePosted over 2 years ago

    Good Job!!!

    If you want to fix the Accessibility Issues you have, try adding a role to the main container. Example <div role="main" class="YourClassHere">

    good luck!

    Marked as helpful
    0
    islombek•280
    @islomurodovPosted about 2 years ago

    @Widoguaiquirian Thank you very much.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord