qr-code-component

Community feedback

• 

  Kevin Walker•140

  @kwalker3000Posted over 2 years ago

  Wow. Nice job, Gaganpreet!

  No accessibility issues, no HTMl issues, and from what I can tell at a glance, your CSS is well structured and organized.

  The only thing that I can think of is maybe adding a README file to your repo. Frontend Mentor gives a good template you can use.

  Best of luck to you, Gaganpreet.

  0

  ---

  

  Gaganpreet Singh•70

  @lorus123Posted over 2 years ago

  @kwalker3000 Thank you for your feedback.

  I see , in mobile the body is scrollable even i set height to 100vh , but still it is scrolling.Do you know any fix for this?

  Thank you.

  0

  

  Kevin Walker•140

  @kwalker3000Posted over 2 years ago

  @lorus123

  I just checked on my phone and there is no issue with scrolling. Are you viewing it on your desktop dev tools? Check your preview window height.

  0

  

  Gaganpreet Singh•70

  @lorus123Posted over 2 years ago

  @kwalker3000 In real mobile using chrome. In which browser you tried?

  0

  

  Kevin Walker•140

  @kwalker3000Posted over 2 years ago

  @lorus123

  I use firefox, and there was no issue. However, after your mention of chrome, I checked and now understand what you mean.

  Apparently, there is an issue with viewport dimensions on mobile, and the browser's address bar. https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-web.html

  I did some debugging, and I think if you remove:

  • height
  • width
  • display: flex
  • justify-content: center
  • align-items: center

  (basically what you're using to center your main element)

  from your body selector and instead add it to the html selector, along with changing your units from vh and vw to percentage, may work.

  0

  

  Gaganpreet Singh•70

  @lorus123Posted over 2 years ago

  @kwalker3000

  After implementing this the issue is fixed now.Thank you for the solution.

  It take 30 minutes to fix this.Because i forgot to compile sass 😒😂.

  0

  

  Kevin Walker•140

  @kwalker3000Posted over 2 years ago

  @lorus123

  Nice!

  Yea, I don't know how many times I have forgotten to compile. Ha

  Glad to hear you got it fixed.

  0