QR-code-component

Community feedback

• 

  Osman Bay•690

  @osmanbay90Posted 9 months ago

  Great job on completing the Frontend Mentor challenge! Your project shows promise, but here are some areas where you could make improvements in your HTML and CSS:

  HTML Structure: Your HTML structure is straightforward, but you could consider using semantic HTML elements for better accessibility and SEO. For instance, you could use <header>, <main>, and <footer> tags.

  CSS Styling:

  • Consolidate duplicate styles: You have .qr class defined twice in your CSS. Combine their styles into one block to avoid redundancy.

  • Use consistent naming conventions: You have a typo in the class name "buildiing." Make sure to use consistent and correct naming conventions to avoid confusion.

  • Improve readability: Break down long CSS rules into multiple lines for better readability. Use shorthand properties: Instead of setting border, border-radius, and height separately, consider using shorthand properties to make your code more concise.

  Responsive Design: Ensure that your design is responsive and looks good on various screen sizes. You may need to adjust widths, heights, and font sizes for different devices.

  Remember, practice makes perfect! Keep refining your skills by tackling more challenges on Frontend Mentor. Happy coding! 🚀

  Marked as helpful

  0
• 

  yasin315•50

  @yasin315Posted 9 months ago

  thank you so much

  0