QR-code-component

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Kalani, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from card class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Kalani, congratulations for your new solution!

  You did a great here putting everything together, but I noticed that you've used too much elements to wrap the content, note that all you need is a single block (main or div) and the content inside of it (img h1 e p). Reducing your html structure like you'll have the cleanest code possible.

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0