Design comparison
SolutionDesign
Community feedback
- @denieldenPosted about 2 years ago
Hi Kalani, congratulations on completing the challenge, great job! π
Some little tips for optimizing your code:
- use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
fromcard
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Hope this help! Happy coding π
Marked as helpful1 - use
- @correlucasPosted about 2 years ago
πΎHello Kalani, congratulations for your new solution!
You did a great here putting everything together, but I noticed that you've used too much elements to wrap the content, note that all you need is a single block (main or div) and the content inside of it (img h1 e p). Reducing your html structure like you'll have the cleanest code possible.
π I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord