@istealersn-dev
Posted
Great efforts! Congratulations on completion of the challenge
When you build HTML, its important that you get the semantics right as that boost accessibility and SEO aspect. In your HTML structure you are missing some important aspects like making sure to include <main>
tag inside body specifying that its the main content of the body and including at least one <h1>
is mandate as per web standards.
On the CSS end, I see you've used a mix of px
and rem
, as a best practise I will recommend to stick to rem
instead of pixels as that will enable good support for user specific browser preferences and accessibility. It uses a base size: 16 (default font size) however you can override that by specifying the root font size within html
tag in CSS, something like this: html { font-size: 15px; }
- this will automatically calculate your pixels based on you the rem values you set.
Hope this is helpful!
Marked as helpful