QR-code-component

Community feedback

• 

  SIDA•190

  @GSida015Posted 6 months ago

  Hello!👋 I reviewed your code, and it's good, but there are some issues that need attention.

  1. You aren't utilizing the provided elements. It's essential to use the materials provided for the solution. Specifically, you should use the provided QR code image. While it's acceptable to use other resources during practice sessions, in a real project assigned by your HR, you should adhere to using the provided materials.

  2. The width and height of the card aren't correct. They should be width: 320px;and height: 497px; respectively. It's preferable to achieve these dimensions by providing exact padding settings.

  For "FREE+" challenges, Figma designs are provided. Even though the dev mode is not currently free, you can still view the widths and heights of elements in the designs.

  I hope my comments were helpful. I would appreciate it if you could mark this as helpful.

  Marked as helpful

  0

  ---

  

  Hassnaa Mahmoud•160

  @HASSNAAMPosted 6 months ago

  Hello!👋

  Thank you for reviewing my code and for your valuable feedback. I understand your points and appreciate the insights you provided.

  My intention was to create a more interactive and realistic project by making the QR code actually scan and direct to the website. I see now the importance of adhering to the provided materials for consistency, especially in a real project scenario.

  Thank you again for your comments. They were indeed helpful, and I will make sure to incorporate your suggestions.

  Best regards, Hassnaa Mahmoud @GSida015

  1

  

  SIDA•190

  @GSida015Posted 6 months ago

  @HASSNAAM Yea I get it now but... Qr code actually scans LOL,it leads you to frontendmentor website.

  0