Aimal Khan• 2,260
@Aimal-125
Posted
In your CSS code, increase the height of body element to 120 or 150vh by using media query with max-height: 400px; so that your solution look good on screens with small heights.
0
Design comparison
Solution retrospective
any feedback is apprecaited
Community feedback
@muhammadui
Posted
In my code review, I observed a few areas that could be improved in your project.
-
Firstly, the image is not loading on the deployed URL, most likely due to its absence in your GitHub repository. Make sure to include all necessary assets for proper rendering.
-
Additionally, the text elements lack consistent center alignment, which can impact the visual appeal and user experience. Aligning the text elements properly will create a more cohesive layout.
-
Lastly, I recommend following the style guide provided by Frontend Mentor to ensure code consistency and readability throughout your project. Implementing these suggestions will greatly enhance the quality and usability of your solution.
Feel free to reach out if you have any questions or need further assistance. Keep up the good work!
0
Dawood Ibrahim• 130
@Dawoodibrahimib
Posted
@muhammadui I'm not sure about what's causing the problem,whenever I upload the folder(ie the project) to a repo in git-hub it somehow fails to load up the images and fonts i've provided it with.This problem seems to persist.I've tried to load it up in VS code and the images and fonts seems to run fine this problem seems to persist in github. would be very grateful if you could help me out with this..!
0
@muhammadui
Posted
@Dawoodibrahimib I apologize for the delay in responding to your messages. I appreciate your patience. I'm committed to helping you resolve the issue you're facing with your project on GitHub. I'll take some time to thoroughly review your code and study the problem so that I can provide you with the best guidance. Please give me a bit of time, and I'll get back to you as soon as I have a clearer understanding of the situation.
Thank you for reaching out, and I'll be in touch soon.
0
Paul Adekomi• 550
@Paul-Adek
Posted
Hi there, Good job 👏 on completing the project, But it seems that you did not upload your image file when trying to upload the project on GitHub, so next time make sure you don't forget the images file. Just an advice, All the best, Happy Coding 😎
0
Dawood Ibrahim• 130
@Dawoodibrahimib
Posted
@Paul-Adek I've tried to upload the image file on git-hub and somehow the image does not load up any idea what seem to be causing the problem? Any kind of help will be appreciated..!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord