qr-code-component

Community feedback

• 

  Doğukan•60

  @dogukan0055Posted about 2 years ago

  Hi there Vodina! Besides the font, your solution looks fine to me! Congrats :)

  Marked as helpful

  0

  ---

  

  Vodina Efem•120

  @SimplyvodaPosted about 2 years ago

  @dogukan0055 Thank you, will work on that :)

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Vodina Efem, congratulations for your first solution! 👋 Welcome to the Frontend Mentor Coding Community!

  Your solution seems great, but you can improve it, changing the font-sizes that for the H1 is around 24px and 16px for the paragraph, also the box-shadow is too much blurry you can reduce it a bit, the value for this shadow is around box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);

  Other thing you can do is remove a little bit some divs and keep all content inside a single div and use relative units as rem or em replacing the px for a better performance.

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Vodina Efem•120

  @SimplyvodaPosted about 2 years ago

  @correlucas Thank you for your feedback, will take all this into consideration :)

  1

  

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  @Simplyvoda I'm happy to hear that Vodina, then tell me if works for you =)

  0