QR_Code-Challenge with HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Nikhil, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • create class istead using inline style. Isen't good way write css inline into html
  • add main tag and wrap the card for improve the Accessibility
  • in the alt attribute of the images insert descriptive text not link
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add padding: 1rem to container class and remove height property
  • remove height and margin-top from img and set width: 100%
  • remove all margin from .container class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh and margin:0 to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1