Submitted over 1 year ago

QR-Code-Challenge solution using Flexbox

Thomas Erdmenger•270

@thomaserdmenger

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

The designs should have been built with the following widths: mobile: 375px and desktop: 1440px. As of I don't think this makes sense since I centered the design and it is centered in both widths. I am wrong with that?

For me it was hard to center the container. My solution was to set the height to 100vh. Is this ok or is there a better solution?

I thank you for any further advice.

Community feedback

Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS 📐:

Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens such as mobile phones in landscape orientation.

For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
0
Thomas Erdmenger•270
@thomaserdmengerPosted over 1 year ago
@0xAbdulKhalid Thank you for your advice!
0
Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
@thomaserdmenger Glad you found it helpful ! 🤠
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord