qr-code-challenge

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states, additionally using max-height is not also a good practice so we want to get rid of that too

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  body {
  min-height: 100vh;
  align-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  body {
  max-height: 1440px;
  padding-top: 15%;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Stanley Nadar•370

  @istealersn-devPosted over 1 year ago

  Great efforts, Congratulations on completing your first challenge

  In order to center the card all you missed was setting the min-height/height while your max-height doesn't help in this case.

  You can either set the as height: 100% or min-height: 100vh as vh stands for viewport-percentage length unit based on the browser default viewport size. This allows the flexbox to align the card at the center as all it needed was height to understand the center axis.

  Hope this helps!

  Marked as helpful

  0