qr-code-card-component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi @Tamunopreye,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • You should use <main> landmark to wrap the card. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.

  • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users. Then you can use <h2> instead of <h3>.

  • In my opinion, the alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image. The alternate text should not be hyphenated , it should be human readable.

  • There are some unnecessary div’s should be removed.

  Overall, Excellent work! Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Tamuno_preye•340

  @TamunopreyePosted over 2 years ago

  @PhoenixDev22 Thank you. Your suggestion were good i'll take note of it for even future references and i will use more of HTML5 too, thank you i'll make the necessary corrections.

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @Tamunopreye Glad it was helpful.Happy coding!

  0