QR_Code with CSS Flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Ubaka, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .white-box class because with flex they are superfluous
  • use flexbox properties to .grey-body class to center the card. Read here -> best flex guide
  • use min-height: 100vh to .grey-body class instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Ubaka•130

  @NgeneubakaPosted almost 2 years ago

  @denielden Thank You Daniel, this has been most insightful.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @Ngeneubaka you are welcome and keep it up :)

  Marked as helpful

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  There is no need for the div with a class grey-body and a div with a class blue-box in the html file. Put all the text content in one div. eg: <div class="white-box"> <img>

  <div class="text"> <h1></h1> <p></p> </div> </div> To center a content on a page type this in the css file: body {min-heigh:100vh; display: flex; align-items: center; justify-content: center;} there is no need for the class center. give the body a color for the colors use the color that was given in the stylguide.md in your starter folder. give the .white -box a padding value and a width. For the img give it a max-width:100%; img{max-width:100%;} For the media query no need to specify a margin value just give the body a percentage value of 80% or 90% Hope am helpful HAPPY CODING.

  Marked as helpful

  0

  ---

  

  Ubaka•130

  @NgeneubakaPosted almost 2 years ago

  @Hassiai Thank you so much hassia, it was all i needed to hear

  0