QR-code with CSS and HTML

Community feedback

• 

  Aditya Singh•460

  @adityas24Posted almost 3 years ago

  Hey Teo! you did very well in your first challenge. I would like to suggest you the following....

  You could have avoided the div you used to wrap the h1 and p. As you have not used any style on div. Then you can simply avoid using it. It will not affect the semantics and will also decrease the length of the code.

  So you could simply write

  <div class="container">
        <img src="images\image-qr-code.png" alt="QR code">
        <h1>Improve your front-end skills by building projects</h1>
        <p class="text">Scan the QR code to visit Frontend Mentor and take your coding skills to the 
           next level</p>
  </div>
  

  All the best 🙂👍

  Marked as helpful

  1
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this one. Viewing your solution I would suggest the following for you...

  • Inside the h1 rule set add margin: 0; and adjust the padding into padding: 1rem 2rem 0 2rem;
  • Same goes with .text add margin:0; and adjust the padding to padding: 1rem 2rem;
  • Instead of using div, wrap the container with specific tag like main for readability

  Hope this helps and Keep up the good work!

  Marked as helpful

  1
• 

  Ken9Code•30

  @Ken9KodehodePosted almost 3 years ago

  Jævla bra jobba kompis! :D

  1