@DavidMorgade
Posted
Hello Nimbul, congrats on finishing the challenge!
The only major fixes that I would made would be setting the viewport of the body to min-height: 100vh
instead of calc(100vh - 1px)
, with this your component would be completely center with your flexbox call!
Also, when you have 2 flex-items inside a flex container, instead of using margin-botton: 2rem
between the component and the attribution, you can use gap: 2rem
on the body, and you will get the same result!
Hope my feedback helped you!
Marked as helpful