Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-Code vanilla css

nimbul30 110

@nimbul30

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Open to suggestions, thanks!

Community feedback

David 8,000

@DavidMorgade

Posted

Hello Nimbul, congrats on finishing the challenge!

The only major fixes that I would made would be setting the viewport of the body to min-height: 100vh instead of calc(100vh - 1px), with this your component would be completely center with your flexbox call!

Also, when you have 2 flex-items inside a flex container, instead of using margin-botton: 2rem between the component and the attribution, you can use gap: 2rem on the body, and you will get the same result!

Hope my feedback helped you!

Marked as helpful

1
Lucas 👾 104,420

@correlucas

Posted

Hello Nimbul, congratulations for your new solution!

I saw your live site and everything works. You can improve a bit the html removing some unnecessary divs and give the box-shadow less opacity to create a smooth shadow.

Here's a tool where you can create shadows online: https://html-css-js.com/css/generator/box-shadow/

Keep it up

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord