Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
QR iMAGE ALT TEXT 📸:
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute.
- The
alt
attribute should explain the purpose of theimage
.
- E.g.
alt="QR code to frontendmentor.io"
<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @khushi0909Posted over 1 year ago
1)you should learn about semantics HTML and using it for ex footer ,main etc
2)image should always have alt="some description". some description about image should always be there for accessibility reasons
https://www.davidmacd.com/blog/alternate-text-for-css-background-images.html
3)Read about h1 tag its the most important and every website should have atleast one https://www.semrush.com/blog/h1-tag/
4)your text is going outside the center
5)i liked that you used the media queries for responsiveness ,but you need to practice a little bit because even with that, in every screen size ,your text are going out of the container and its not good
All the best
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord