Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-code Updated

Giovanniโ€ข 30

@MagnificoRettore

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas ๐Ÿ‘พโ€ข 104,420

@correlucas

Posted

๐Ÿ‘พHi Giovanni , congratulations for your first solution!๐Ÿ‘‹ Welcome to the Frontend Mentor Coding Community!

Great solution and great start! By what I saw youโ€™re on the right track. Iโ€™ve few suggestions to you that you can consider to add to your code:

Donโ€™t use id to give the style of your elements, it's not a good idea because id is a too specific selector used for forms and Javascript code. Instead, use class for styling and let the id for much specific stuff. It's also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.

โœŒ๏ธ I hope this helps you and happy coding!

Marked as helpful

0

Giovanniโ€ข 30

@MagnificoRettore

Posted

@correlucas Ah got it! In the next exercises, I'll use class selectors on my css file

0
Vincent Danielโ€ข 410

@davinceey

Posted

Hello Giovanni. Congratulations on your first project! This is a beautiful design on the whole. Just some little tips to help: You might want to replace the p tag in this code <p id="title">Improve your front-end skills by building projects</p>, with a h1 tag. This would help improve Accessibility as your article semantic tag, would have a level one heading.

Hope this helps you. Happy Coding!๐Ÿ‘Š

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord