Design comparison
Community feedback
- @correlucasPosted about 2 years ago
๐พHi Giovanni , congratulations for your first solution!๐ Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw youโre on the right track. Iโve few suggestions to you that you can consider to add to your code:
Donโt use
id
to give the style of your elements, it's not a good idea becauseid
is a too specific selector used forforms
and Javascript code. Instead, useclass
for styling and let theid
for much specific stuff. It's also not advisable to use IDs as CSS selectors because if another element in the page uses the same/similar style, you would have to write the same CSS again. Even if you don't have more than one element with that style right now, it might come later.โ๏ธ I hope this helps you and happy coding!
Marked as helpful0@MagnificoRettorePosted about 2 years ago@correlucas Ah got it! In the next exercises, I'll use class selectors on my css file
0 - @davinceeyPosted about 2 years ago
Hello Giovanni. Congratulations on your first project! This is a beautiful design on the whole. Just some little tips to help: You might want to replace the p tag in this code
<p id="title">Improve your front-end skills by building projects</p>
, with ah1
tag. This would help improve Accessibility as yourarticle
semantic tag, would have a level one heading.Hope this helps you. Happy Coding!๐
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord