Skip to content
Submitted 10 months ago

Qr-code solution

Yousef Zamanpour•230
@YousefZamanpour
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Øystein Håberg•10,550
    @Islandstone89Posted 10 months ago

    Hello - here is my feedback :)

    HTML:

    • IMPORTANT: <footer> must NOT be outside of <body>! The body is the container for all of the content on a page.

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Since the card is the only "main" content on this page, you can change .container into a <main>. You don't need <article or the .wrapper, so remove those.

    • The text in .attribution must be wrapped in a <p>.

    CSS:

    • It's good practice to include a CSS Reset at the top.

    • You are using rem for font-size, which is the correct thing to do. However, you have a Custom Property (fs-p) with a px value. Never use px for font-size - this prevents users from overriding the default font size set in the browser, which makes a site inaccessible.

    • max-width on the card should be in rem - 20rem equals 320px, and is a good value to use.

    • Remove min-height and margin on the card - neither of them is needed.

    Marked as helpful
    0
    Yousef Zamanpour•230
    @YousefZamanpourPosted 10 months ago

    Hey @Islandstone89 thx for your insightful comment, I appreciate it. and I'll be looking forward to your comments on my future challenges.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord