QR-Code solution

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @stwslim83, Congratulations on completing this challenge!

  Here is my feedback:

  • Don't use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings.

  Keep doing a good job!

  Marked as helpful

  1

  ---

  

  Justin•50

  @stwslim83Posted about 2 years ago

  @Deolabest thanks for the input, i'll def start incorporating rem then :-)

  0
• 

  Ahmed•400

  @AhmedLebdaPosted about 2 years ago

  Hi @stwslim83, congrats on completing this one

  • You can use <main> instead of <div> to improve the accessibility of your page.
  • Adding max-width: 1440px and min-width: 375px to the body element won't make the content centered properly in screens larger than 1440px or lower than 375px , you can remove those styles and replace it with a margin: 20px for the wrapper div to avoid card touching screen edges in smaller screens

  Marked as helpful

  0
• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  I forgot to add this:

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  Marked as helpful

  0

  ---

  

  Justin•50

  @stwslim83Posted about 2 years ago

  @Deolabest will do, thank you. Looking at my solution, it looks like my solution is smaller. I thought I set the size of the project closer to the solution. Any input on where i went wrong there would be helpful also.

  0