Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Solution to QR Code Challenge

@csphilli

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm still trying to learn where to apply the specific Aria roles. Also, regarding the h3, since this is just a random QR on some empty page, the h3 is a guess.

Do <p> elements get an Aria role or should I have included that single element inside an <article> element?

Community feedback

@Julia-Fidison

Posted

Hello, Good job. I would like to give you a few suggestion if you don't mind.

In your html code. It will be easier for you and the other if you follow the html semantics for example <main class="container"> <img> <article> <h1>.......</h1> <p>.......</p> </article> </main> Concerning the heading I think you should always start with <h1> <h2> <h3> .... You can't go to h2 after h1, they need to follow a chronological order if you want to change the font-size of your heading just override it in you css Learn more about that here And more about the html semantics

0

@csphilli

Posted

My challenge preview might be buggy. Netlify is having some performance issues today.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord