Skip to content
Submitted over 2 years ago

Solution to QR Code Challenge

Christopher Phillips•30
@csphilli
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm still trying to learn where to apply the specific Aria roles. Also, regarding the h3, since this is just a random QR on some empty page, the h3 is a guess.

Do <p> elements get an Aria role or should I have included that single element inside an <article> element?

Community feedback

  • Julia Fidison MAHANDRISOA•90
    @Julia-FidisonPosted over 2 years ago

    Hello, Good job. I would like to give you a few suggestion if you don't mind.

    In your html code. It will be easier for you and the other if you follow the html semantics for example <main class="container"> <img> <article> <h1>.......</h1> <p>.......</p> </article> </main> Concerning the heading I think you should always start with <h1> <h2> <h3> .... You can't go to h2 after h1, they need to follow a chronological order if you want to change the font-size of your heading just override it in you css Learn more about that here And more about the html semantics

    0
  • Christopher Phillips•30
    @csphilliPosted over 2 years ago

    My challenge preview might be buggy. Netlify is having some performance issues today.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord