@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.
body {
justify-content-center;
}
- Now remove these styles, after removing you can able to see the changes
.frame {
margin: 0 auto;
}
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@anthonyplicata
Posted
@0xAbdulKhalid Thanks so much! That advice is super helpful. I kept adding justify-content: center but was not doing anything, and I assume it was because I had too much going on with margin and padding for flexbox to really be used.
@0xabdulkhaliq
Posted
@anthonyplicata Glad you found it helpful ! 🤠