Qrcode scanner using HTML and CSS Challenge

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Amit, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the span container of image
  • use p for the text of card and not a h4 tag
  • use min-height: 100vh to body instead height: 100%

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Amit Dhakal•490

  @herojk64Posted over 2 years ago

  @denielden thanks man suggestions like this helps us improve

  1