Design comparison
Community feedback
- @Nick-GabePosted almost 3 years ago
Hi Ibrahim! Great you completed the challenge. I couldn't see your code, because the link may be wrong, but by looking at the website I have some suggestions:
Im on mobile right now, and the qr-code container is really tiny. To make it responsive, one of the approaches is making a variable width (using % or vw) and a fixed max-width so it doesnt stretch forever. The same can be applied to height.
If you have any questions, feel free to ask.🙂 See ya
0 - @NaveenGumastePosted almost 3 years ago
Hay ! Good Job ibrahim guenichi
These below mentioned tricks will help you remove any Accessibility Issues
-> Add
Main
tag after body like it should be your container. For 1st heading orh1
tag, use header tag and then inside the header put yourh1
orh2
etc . But use header tag only once in main heading element.Keep up the good work!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord