QR-CODE Project using HTML & CSS.

Community feedback

• 

  Sam•230

  @samd1aPosted over 2 years ago

  Hi ELKady, congrats on finishing your first challenge it looks great! To answer your question, removing the height: attribute from your #bold and #light properties will allow for the text to expand down as the viewport width gets smaller, it also prevents the overlapping you have.

  Also swap your <section> landmark for a <main> landmark, this allows for the page to be more accessible to screen readers. I would suggest changing your <p id="bold"> to a <h1 id="bold"> for the same reason.

  You were so close to centring your card, just add:

  html {
      height: 100%;
  }
  

  Hope this helps, keep coding!

  Marked as helpful

  0

  ---

  

  Kady•10

  @goushaaPosted over 2 years ago

  @samd1a
  Thank you so much for taking your time to review my code. Your words are so helpful to me ❤

  0