QR-Code Project

Community feedback

• 

  Kinga Miśkiewicz•160

  @codingbearyPosted over 1 year ago

  Hi! Great work!

  I have a few tips how you can improve this project :)

  • You can put the attribution into a footer for better semantics (it help screen readers, search engines etc understand your website better, because the div itself doesn't have any semantic value)
  • You're using different font that the one in the design, but you can fix it by finding this particular font on google fonts (you can find it's name in the starter pack in a file called "style guide"). If you have troubles with importing the font, let me know, I'll help you do it :)

  In general you did a really great work, keep it up! I hope my tips were helpful! :)

  Marked as helpful

  0

  ---

  

  Gaurang Saini•40

  @gaurangsaini01Posted over 1 year ago

  @kiyooteru ThankYou much appreciated !

  0
• 

  Rebecca Padgett•1,840

  @bccpadgePosted over 1 year ago

  Hello @gaurangsaini01. Congratulations on completing this challenge !!🎉

  I would love to give you some feedback but when I click view code link it says the repository is not found.

  Hope this helps you and don’t hesitate to reach out me if you have any questions

  Marked as helpful

  0

  ---

  

  Gaurang Saini•40

  @gaurangsaini01Posted over 1 year ago

  @bccpadge Hey , Thanks for connecting first of all , secondly I have corrected the path to repository , please check again .

  0

  

  Rebecca Padgett•1,840

  @bccpadgePosted over 1 year ago

  @gaurangsaini01,

  My pleasure 😇

  My suggestion would be to import the google font (link to the font is in the styleguide.md file) and make sure to use heading tags in chronological order. Example below ⬇️

  <h1>Improve your front-end skills by building projects<h1>

  0