Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code

salahdine 100

@salahdinebocuif

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of making this project and hope for development in the future

What challenges did you encounter, and how did you overcome them?

Control the elements

What specific areas of your project would you like help with?

everything

Community feedback

@alberto-rj

Posted

Hi, @salahdinebocuif! Congratulations on investing your time and leveling up with the challenge, QR code component.

I have some code suggestions about your CSS Style in the file index.css that can help you improve your solution to this challenge.

  • Use the rem unit: It is good practice to use the rem unit to specify the font-size, margin, padding, width, height..., instead of the px unit. Learn more here.

  • Line 10: You could use min-height: 100vh, instead of height: 100vh, in the body selector to avoid content overflow. Learn more here.

  • Line 22: Removes the height: 450px property from the .container selector. By doing this, you will avoid overflowing the content of the p element.

  • Use margin or padding: Add spacing on the left and right side of the p element to prevent the text from sticking to the card.

  • Line 28 to 29: Replace the width:240px and height: 260px declarations with width: 100% and height: auto to make the QR code image responsive.

Keep learning, coding and sharing! 🌟

Happy coding! 🚀

Marked as helpful

0
Anuj Gupta 250

@AnujCodeIt

Posted

  • The size of the container is small
  • You have not used the proper spacing (like padding on left and right)
  • You have not used shadow

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord