@alberto-rj
Posted
Hi, @salahdinebocuif! Congratulations on investing your time and leveling up with the challenge, QR code component.
I have some code suggestions about your CSS Style in the file index.css
that can help you improve your solution to this challenge.
-
Use the
rem
unit: It is good practice to use therem
unit to specify thefont-size
,margin
,padding
,width
,height
..., instead of thepx
unit. Learn more here. -
Line 10: You could use
min-height: 100vh
, instead ofheight: 100vh
, in thebody
selector to avoid content overflow. Learn more here. -
Line 22: Removes the
height: 450px
property from the.container
selector. By doing this, you will avoid overflowing the content of thep
element. -
Use
margin
orpadding
: Add spacing on the left and right side of thep
element to prevent the text from sticking to the card. -
Line 28 to 29: Replace the
width:240px
andheight: 260px
declarations withwidth: 100%
andheight: auto
to make the QR code image responsive.
Keep learning, coding and sharing! 🌟
Happy coding! 🚀
Marked as helpful