qr-code made with HTML & CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @hkmarcoot 👋, good job completing this challenge! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="all-container">.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • Centering the element with position would make your element behave strangely on some mobile devices. There are two modern CSS techniques to center elements:

  Using flexbox layout:

  body {
     min-height: 100vh;
     display: flex;
     flex-direction: column;
     justify-content: center;
     align-items: center;
  }
  

  Using grid layout:

  body {
     min-height: 100vh;
     display: grid;
     place-content: center;
  }
  

  Links with more information:

  • The Complete Guide to Centering in CSS.
  • A Complete Guide to Flexbox (CSS-Tricks).
  • How TO - Center Elements Vertically (W3Schools).
  • CSS Layout - Horizontal & Vertical Align (W3Schools).

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  Marked as helpful

  1

  ---

  

  Marco Tsang•50

  @hkmarcootPosted almost 2 years ago

  Thank you @MelvinAguilar . I have made changes based on your suggestions.I have completed the first three, and would do the remain two in other project so that I can keep a record what I did in the learning journey.

  0
• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi Marco Tsang, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  As you know this project is based only on one page component, so no h1 is needed! because we don't know if this page will have a more important component, but it's always good to prevent accessibility errors so I think it would be good for you to add an h1 in this component, besides being a good practice for when you are developing larger sites, don't worry forget about h1.

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Marco Tsang•50

  @hkmarcootPosted almost 2 years ago

  Thank you @AdrianoEscarabote . I will use rem instead of px in my next project. Now I will just leave the rem problem and centring problem (as mentioned by Melvin) here as I want to keep track my work in the learning journey.

  0