qr-code

Community feedback

• 

  Jon Hill-Upperton•150

  @JonhilluppertonPosted over 2 years ago

  Hello Eric,

  Great on submitting the project.

  Couple bits of advice, use <main class=“container”> instead of <div class=“container”> also the font info is in the style guide.

  On the CSS place min-height: 100vh, display flex, justify-content: center and align-items: center in the body tag this will place the container middle of the screen and then on the .container CSS put max-width: 320px and don’t worry about putting heights in the others, as they will predict the overall height and you can increase each element with padding and margin.

  Thanks

  Jon

  Marked as helpful

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. .

  Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="container"> instead of <div class="container"> and your footer should be <footer class="attribution" instead of <div class="attribution".

  This should fix most of your accessibility issues.

  To answer your question, all resources needed for a project can be found in the styles-guide.md the font-family is specified there with a link to get it.

  . Regardless you did amazing... hope you find this helpful... Happy coding!!!

  0
• 

  Saul•1,260

  @xsaulPosted over 2 years ago

  Hello Eric the correct font will always be in the file "style-guide.md". But here it is: Family: Outfit Weights: 400, 700

  0