@RogelioCamargo
Posted
I love that you used CSS variables. It looks like your solution isn't responsive. I personally suggest taking a mobile-first approach.
Marked as helpful
Hi folks, this is my first challenge on frontend mentor. I look forward to any feedback, as I want to improve my coding skills.
Greetings!
@RogelioCamargo
Posted
I love that you used CSS variables. It looks like your solution isn't responsive. I personally suggest taking a mobile-first approach.
Marked as helpful
@Hassiai
Posted
Add the alt attribute alt=" "
to the img tag and give it a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.
There is no need to give the root a background-color and display: flex and its properties. There is no need to give the body a width and height values.
To center .container on the page using flexbox, add min-height:100vh
to the body.
For a responsive content,
max-width: 320px which is 20rem/em padding:16px which is 1rem/em
Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord