QR-code integration, plain html &css

Community feedback

• 

  P

  RogelioCamargo•200

  @RogelioCamargoPosted over 1 year ago

  I love that you used CSS variables. It looks like your solution isn't responsive. I personally suggest taking a mobile-first approach.

  Mobile First Design

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  <div class="attribution"> should be out of the main tag <main> and wrap in a footer tag.

  Add the alt attribute alt=" " to the img tag and give it a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

  There is no need to give the root a background-color and display: flex and its properties. There is no need to give the body a width and height values.

  To center .container on the page using flexbox, add min-height:100vh to the body.

  For a responsive content,

  • Relace the width in .container with max-width, reduce its value and the height with a padding value for all the sides max-width: 320px which is 20rem/em padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0