QR-Code HTML5 CSS3

Community feedback

• 

  Adriano•38,060

  @AdrianoEscarabotePosted almost 2 years ago

  Hi PadseGaming, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  To improve the responsiveness of the project we can make a very important change!

  #card {
      max-width: 300px;
  }
  

  Add a padding to the body, so that the content in lower resolutions doesn't hit the edge of the screen!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  PadseFIAE•70

  @PadseFIAEPosted almost 2 years ago

  @AdrianoEscarabote Hello Adriano, thank you for the nicely Words, too. :-) I'm fine and i hope u to!

  I will heed your tip and implement it in future projects.

  Best regards Patrick :-)

  1
• 

  Abdullah Yakub•40

  @developerabzPosted almost 2 years ago

  Hey looks alright. Your img tag did trigger the html report for accessibility so make sure you add some alt="" text. Also, the card should be at least 10% larger on desktop. I checked on different screens and also scaled down the screen but I dont seem to be running into footer going to the left problem. Your footer seems to also be fine stuck to the bottom but you could in some situations also use 'margin-top: auto;' in the footer css to stick it to the bottom

  Marked as helpful

  0

  ---

  

  PadseFIAE•70

  @PadseFIAEPosted almost 2 years ago

  @developerabz Thank u for your nicely words. Yes i forgotten the alt="" text on the IMG. Thanks for this hint and thank your very much for the hint with margin-top auto for the footer :)

  0