qrcode - HTML and CSS solution desktop

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @csdemaria!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Mariusz•120

  @MariusG1991Posted 10 months ago

  Hi,

  Great work, but instead of using position relative to center your component, the easier way is to use flexbox or grid.

  Flexbox solution

  body{
    display: flex;
    justify-content: center;
    align-items: center;
    min-height: 100vh;
  }
  

  0
• 

  fahadrafiq16•0

  @fahadrafiq16Posted 10 months ago

  It needs mobile and tablet responsiveness. Set main block to center by using flex properties. It does not have margin at bottom on desktop.

  0