Skip to content
Submitted almost 2 years ago

qr-code first lesson

jp-lavratti•40
@jp-lavratti
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

my first site on Frontend-Mentor, it was very easy, the most difficult thing for me was trying to fix the footer at the bottom of the page using flexbox, but I couldn't because it wasn't set as a flex-item, so I used transform and it worked

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hello there 👋. Good job on completing the challenge !

    I have some suggestions about your code that might interest you.

    HTML 🏷️:

    • Wrap the page's whole main content in the <main> tag.

    CSS 🎨:

    • Use more descriptive class names to improve readability of front-end code. You can learn BEM naming convention to improve your class names.
    • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.
    • In the html element it is not necessary to add any style to center elements, use directly in the body element.

    I hope you find it useful! 😄

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord