Skip to content
Submitted 8 months ago

QR-Code

SAMAtech22•70
@SAMAtech22
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

what are my mistakes and i used margin a lot to centralize the desktop view, is there any other way?

What challenges did you encounter, and how did you overcome them?

what are my mistakes and i used margin a lot to centralize the desktop view, is there any other way?

What specific areas of your project would you like help with?

all coorections

Community feedback

  • Boris•2,850
    @mkborisPosted 8 months ago

    Hi SAMAtech22, great job on attempting this challenge, here are some suggestions to improve your work

    • All content should be wrapped within landmarks. Wrap a main tag around the container and a footer for the attribution.

    • You don't need media queries for this challenge, remove the media queries and make this minor improvements

    • on your body add

      display: flex;
  align-items: center;
  justify-content: center;
  flex-direction: column;
  min-height: 100vh;
    • Your container should have a max-width: 20rem;
    • .container img should be max-width: 100%; not width. Avoid using fixed widths on items use max-width if you have to.
    • Also font-size should be in rem not px.

    Hope this helps.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord