QR-code desktop version (basic css + flexbox)

Community feedback

• 

  P

  Gerardo Cianciulli•190

  @GerardoCianciulliPosted over 1 year ago

  There are about a dozen html tag that you may want to use on a regular basis. Selecting the correct tag helps with SEO, CSS and javascript . Looking over your html I noticed the use of div, span and section in ways that can cause you trouble for more complex projects. Example

  <div class="title"> <span class="main_title">Improve your front-end skills by building projects</span> </div>

  should be

  <h1>Improve your front-end skills by building projects</h1>.

  This helps SEO "search engine optimization" by adding a heading level 1. It also helps you with your CSS. Since you can only ever use one H1 per html you don't need to create a title class and can style the H1 directly.

  Marked as helpful

  0

  ---

  

  Akram Lahmouri•20

  @AkramLahPosted over 1 year ago

  @GerardoCianciulli Thanks , indeed now that you brought that up i see how clunky my code is . I still d'ont have knowlage about SEO that's somethin a surely will loo into in the future .

  0
• 

  Megan Kullu•180

  @MeganKulluPosted over 1 year ago

  Hey, I like your approach to the problem. You can consider placing all your tags inside the container div so that all the code is in one view as you have assigned it the 100vh height. :-)

  0
• 

  Ishita•180

  @ishitaraina1807Posted over 1 year ago

  hey! you can add shadow using "box-shadow". it will make it even closer to the real design :)

  0

  ---

  

  Akram Lahmouri•20

  @AkramLahPosted over 1 year ago

  Thanks , i'll try to add that when i'll rework the project@ishitaraina1807

  0