QR-Code Design

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @mohit-sonii!

  Your solution looks great to me!

  If you change the background-color to #D6E1F0 and use the recommended font-family (I think it's Outfit) it'll look even closer to the original design 😁

  I hope it helps!

  Other than that, excellent job!

  1

  ---

  

  Mohit Soni•20

  @mohit-soniiPosted 11 months ago

  Thank you @danielmrz-dev for the comment. Actually I forget to look on the guidelines. 😁

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  CSS 🎨:

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  I hope you find it useful! 😄

  Happy coding!

  1

  ---

  

  Mohit Soni•20

  @mohit-soniiPosted 11 months ago

  Thank you @MelvinAguilar for the wonderful suggestions. I understand you point and will work upon to make it better.

  1