QR-Code design for Mobile and Desktop Screens

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="attribution"> element with the proper semantic element <footer> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Ernest Anyewe Adonu•110

  @principlebrothersPosted over 1 year ago

  Thank you Abdul Khalid for the comment and thank you to everyone who likes my work.

  I have fixed all the issues you raised. I hope it looks better now with the semantics.

  How do I change the link I submitted since it is a preview link and I have it with a new one in my README.md file

  0

  ---

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @principlebrothers Yeah sure, you can edit the solution as much as you want without any limitations by clicking the three dots button in this solution, then you can select the edit solution option to edit your links, title, questions etc.

  0

  

  Ernest Anyewe Adonu•110

  @principlebrothersPosted over 1 year ago

  Abdul Khalid, Thank you so much.

  I have done that and the report came out with an issue.

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Excuse me @principlebrothers, Does the report generated new issues?. I can't get right what are you trying to say

  0

  

  Ernest Anyewe Adonu•110

  @principlebrothersPosted over 1 year ago

  AbdulKhalid , I meant that no issues were generated this time round when I updated my code with your suggestions.

  I hope it is clear now :smile.

  Thank you

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @principlebrothers Wow, Glad to hear that, and glad you found my feedbacks helpful ! 🤠

  0