Submitted 10 months ago

QR-Code CSS/HTML

Sarah Cooper• 30

@SarahCooper-TC

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Can you use Display: block instead of Display: flex for this?

Community feedback

_nehal💎• 6,710

@NehalSahu8055

Posted 10 months ago

Hello Coder 👋

Congratulations on successfully completing the challenge! 🎉

Few suggestions regarding design.

Use min-height:100vh instead of height:100vh To dynamically center the card

body{  
    display: flex;
    justify-content: center;
   align-items: center;
   min-height: 100vh;
   ...
}

Use Semantics for the proper design of your code.

<body>
<main>... main content goes here ...</main>
<footer>... .attribution div goes here ... </footer>
</body>

For non-decorative images give meaningful and descriptive alt like alt= "QR code to frontend mentor website".
Use responsive units(rem, em, %) from next project. Explore respective use cases on google.

I hope you find this helpful.

Happy coding😄

Marked as helpful

Sarah Cooper• 30

@SarahCooper-TC

Posted 10 months ago

@NehalSahu8055 Thank you for your feedback! This helps! I will explore responsive units (rem, em, %) on google!

Ryoshi1001• 140

@Ryoshi1001

Posted 10 months ago

Hope can be good webpage made looks very good and almost same as design . @nehalSahu8055 added many good things that you can add if needed and gives better control of the page. Already have disply:flex for body of html that is needed to center the qr card in the middle of screen unless made new div/section/main element than used that for centering. A main div would be good that way you can put the attribute at the bottom of the webpage.

If question is about display block instead of flex for the .box class name you made than you can erase flex from it since everything in the qr card are block elements and use padding to make it look ok I changed a few things in your css and html for you to also try hope this helps thank you take care gn gm frens body { height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; background-color: hsl(205, 73%, 88%); }

.box { width:288px; height: auto; padding: 14px; text-align: center; border-radius: 20px; background-color: hsl(0, 0%, 100%); }

img { width: 288px; height: 288px; border-radius: 10px; }

Marked as helpful

Sarah Cooper• 30

@SarahCooper-TC

Posted 10 months ago

@Ryoshi1001 Thank you for your feedback! I have added more semantics for additional accessibility.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord