QRcode component with pure HTML and CSS

Community feedback

• 

  Dev Rathore•2,600

  @GitHub-dev12345Posted almost 3 years ago

  Congratulation to complete the challenge ❤️👍 My small suggestion : 1.In Card design CSS Code Used this:

  transform : scale(0.8); this property decrease the size of card. 😉

  large size for increase the number of scale & small size for decrease the number of scale

  I hope you find this helpful

  Marked as helpful

  1
• 

  Muh Suryadi Triputra Rahman•400

  @msuryaditriputraRPosted almost 3 years ago

  I think you only need to put your CSS style on your stylesheet, not in inline style HTML tags

  for easy to readable, maintainable, and to be consistent

  Marked as helpful

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted almost 3 years ago

  You can also practice using rem across your stylesheet to be consistent with your css units.

  Marked as helpful

  0
• 

  Robert Macwan•160

  @Robert170304Posted almost 3 years ago

  it's perfect there is no need to change anything. yeah if you want then you can improve it's height. if you do that then it will be exactly same as challenge.

  Marked as helpful

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hello SINUT WATTANRPORN ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • The sub-text is very light colored so make it dark

  -card and qr img make it less rounded

  happy Coding😀

  0