@vanzasetia
Posted
Hi, DNel!
Congratulations on completing this challenge!
Nice alternative text for the QR code! It is rare to see people that can write good alternative text. Amazing! 👏
I recommend removing all commented code. If other developers or yourself in the future work with the same code base, they can get confused about whether the commented code should be used or deleted.
I recommend making the body
as a flex container to place the card in the center of the page. Then, there is no need for a wrapper to have margin-top: 15%
. Be aware that using percentage unit for margin
and padding
can lead to unexpected results on some screen sizes. It is because the value (computed value) is relative. So, it is better to use a static unit (rem
) to make sure it is consistent across screen sizes.
I suggest using a CSS reset whenever you start a new project. This can help you set the styling foundation easily.
Read more — A Modern CSS Reset
I hope this helps. Happy coding!
Marked as helpful
@TechEdDan2
Posted
@vanzasetia Thank you for all of your helpful notes and suggestions.
@vanzasetia
Posted
@TechEdDan2 Happy to hear that was helpful! 😊