Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- This solution had generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@Gems-coderPosted over 1 year ago@0xAbdulKhalid Thanks for the feedback, it is helpful for now and the rest of my coding life. Am grateful.
0 - @tobezhanabiPosted over 1 year ago
Hi there Nice job Next time, be sure to use a level one heading for accessibilityβs sake.
Generally, it is a best practice to ensure that the beginning of a page's main content starts with a h1 element, and also to ensure that the page contains only one h1 element.
You should always have h1 tag on your site, and they should follow the hierarchical order. i.e. h1> h2> h3 till h6
Overall, you did a fantastic job,
happy coding
Marked as helpful0@Gems-coderPosted over 1 year ago@tobezhanabi wow.. i never knew the importance of using my headings tag following the hierarchical order but thanks to your feedback. i just learned something new. I appreciate and expect to learn more from your future feedbacks. thanks.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord