Skip to content
Submitted about 2 years ago

QR-CODE COMPONENT USING HTML&CSS

Zayaβ€’10
@DINIPRE
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi, so i just concluded my first project and I'd appreciate it if you check it out for me. I'd love to get feedback on my work. Thanks.

Community feedback

  • Gautham R Vanjreβ€’480
    @GauthamRVanjrePosted about 2 years ago

    Hello Zaya, first all of welcome to the front-end mentor. I saw your result code and here are some improvements you can make from my side.

    1. give some padding to the image inside the card
    2. margin-bottom to the image looks a bit cluttered
    3. try to reduce the height of the card div , it looks too big for this challenge. Thank you.
    Marked as helpful
    0
    Zayaβ€’10
    @DINIPREPosted about 2 years ago

    @GauthamRVanjre Yes, Thank you so much, I'll make those changes

    0
  • Lucas πŸ‘Ύβ€’104,340
    @correlucasPosted about 2 years ago

    πŸ‘ΎHi @DINIPRE, congratulations on your solution!πŸ‘‹ Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    1.Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    2.Add the correct size to avoid the container growing more than it should. In this case the QR CODE component size is max-width: 320px.

    3.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

    To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link β†’ https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

    4.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    1
  • バレンタむン πŸ˜ˆβ€’64,170
    @VCaramesPosted about 2 years ago

    Hey@DINIPRE , some suggestions to improve you code:

    • QR Image has to have following on it (should be part of your CSS Reset) to make it responsive:
    img {
 max-inline-size: 100%;
  block-size: auto;
}
    • When you use images/icons, you want to include an Alt text tag with them. Inside that Alt Tag you want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

    If the image/icon is decorative, then you will leave the Alt tag blank; alt=β€œβ€

    • Uno Class width has to be a max-width in order for card to be responsive.

    • Remove height from Uno Class, your content will create the height.

    • CSS styling needs to be in a separate file and be attached to the HTML file with an Link Tag.

    Happy Coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord