qr-code component using html and css

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Franklin, Congratulations on completing this challenge!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  3.Remove width: 1440px to make the proper alignment:

  body {
      display: flex;
      background-color: var(--color-light-gray);
      justify-content: center;
      align-items: center;
      height: 100vh;
      /* max-width: 1440px; */
  }
  

  Note that these sizes given in the style-guide.md in the case 1440px for desktop and 375px are only a reference value to say in which dimension the design were created, don't stick to these values because your solution should be fully responsive and fit any screen size.

  ✌️ I hope this helps you and happy coding!

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @frankbush-cloud,

  Congrats on completing the challenge

  remove the max-width: 1440px on the body rule. There is no need to use a media query in this challenge. For the .container div you can swap it with a main tag so it will be <main class="container">

  You did good. Hope this is helpful.

  0