QR-Code Component using flexbox

Community feedback

• Account deleted

  Hi Trenton 👋 Congrats on finishing your first challenge!

  Your design looks very similar, just a few little things:

  The width of the container element is 325px actually and you need to increase the padding inside of it - to 15px I would say.

  Also, the heading and paragraph should be closer together, and consider replacing the h2 element with h1 because of the accessibility issues.

  I hope that helps.

  Other than that, looks great. Keep up the good work! 👨‍💻💪

  Marked as helpful

  0

  ---

  

  Trenton Bensheimer•190

  @tbensheimerPosted over 2 years ago

  @kom42ec Thank you for your help and for your response! May I ask, how did you know the width of the container is 325px? There is no details that mentions the width of the container, just the mobile and desktop widths.

  Thank you again!

  0

  Account deleted

  @tbensheimer I didn't know.

  I just looked at the mobile design which is 375px wide and saw a padding on both sides that is approximately 25px each. So I substracted those 2 x 25px from 375px and I got 325px.

  But I might be wrong, now I see people use 320px as a width, maybe they got the Figma files and it's provided there.

  When you don't have the details all you can do is use your best judgment. So that's what I did :)

  0