QR-Code component using CSS Grid

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  newtothis90•240

  @newtothis90Posted over 1 year ago

  @0xAbdulKhalid I used the <h3> for sizing purposes only. What if I was to remove the <h*> element completely and just wrap the text in a different element, such as <p>, and then adjust the size with that? Would that be a better way to do this?

  0
• 

  Rau•250

  @raubacaPosted over 1 year ago

  Hi,

  You can improve your code by learning semantic HTML elements. For example, you can replace the container <div id="container" role="main container"> with <main id="container">. Another thing could be, don't use ids (#id) for styles, use classes (.class) instead. Good work!

  Marked as helpful

  1

  ---

  

  newtothis90•240

  @newtothis90Posted over 1 year ago

  @raubaca Thanks a lot for the advice. I'll most certainly look into semantic HTML. I'll also look more into depth of when to use classes vs. ids.

  Thanks for taking the time out to review it.

  0